Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpolation added for TVP. #30863

Merged
merged 12 commits into from
Jun 7, 2024
Merged

interpolation added for TVP. #30863

merged 12 commits into from
Jun 7, 2024

Conversation

bhuvanmdev
Copy link
Contributor

What does this PR do?

Adds interpolation to the tvp model for the position and pad embeddings.

Addresses #30579

Who can review?

@amyeroberts

amyeroberts
amyeroberts reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on adding this!

src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
tests/models/tvp/test_modeling_tvp.py Outdated Show resolved Hide resolved
tests/models/tvp/test_modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Show resolved Hide resolved
@amyeroberts amyeroberts mentioned this pull request May 21, 2024
Open
11 tasks
amyeroberts
amyeroberts reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued work on this!

Please make sure to either comment on suggestions why you're not implementing them or implement the suggestion before marking as resolved. Comments making suggestions to make e.g. docstrings in-line with the library standard will have to be implemented

tests/models/tvp/test_modeling_tvp.py Outdated
Comment on lines 300 to 301
expected_shape = torch.Size((1, 2))
assert outputs.logits.shape == expected_shape
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 2 :)

src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
@amyeroberts
Copy link
Collaborator

@bhuvanmdev For the quality checks could you:

  • Rebase on main
  • Make sure the most recent formatting libraries are installed: pip install -e '.[quality]'
  • Format with make fixup

@bhuvanmdev
Copy link
Contributor Author

bhuvanmdev commented May 25, 2024 •
edited
Loading

Done. Did I miss any changes to make? @amyeroberts

amyeroberts
amyeroberts reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued work on this!

Just a few final things to address before merge

src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
src/transformers/models/tvp/modeling_tvp.py Outdated Show resolved Hide resolved
amyeroberts
amyeroberts approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@amyeroberts amyeroberts merged commit 3b9174f into huggingface:main Jun 7, 2024
18 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 14, 2024
@bhuvanmdev @zucchini-nlp
interpolation added for TVP. (huggingface#30863)
52a1319 
* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* docstring and argument fix

* doc fixes and test case fix suggested in review.

* varibale typo fix

* styling and name fixes for padding interpolation flag.
itazap pushed a commit that referenced this pull request Jun 17, 2024
@bhuvanmdev @itazap
interpolation added for TVP. (#30863)
23849b9 
* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* docstring and argument fix

* doc fixes and test case fix suggested in review.

* varibale typo fix

* styling and name fixes for padding interpolation flag.
itazap pushed a commit that referenced this pull request Jun 17, 2024
@bhuvanmdev @itazap
interpolation added for TVP. (#30863)
2a84256 
* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* docstring and argument fix

* doc fixes and test case fix suggested in review.

* varibale typo fix

* styling and name fixes for padding interpolation flag.
itazap pushed a commit that referenced this pull request Jun 17, 2024
@bhuvanmdev @itazap
interpolation added for TVP. (#30863)
12da461 
* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* docstring and argument fix

* doc fixes and test case fix suggested in review.

* varibale typo fix

* styling and name fixes for padding interpolation flag.
itazap pushed a commit that referenced this pull request Jun 20, 2024
@bhuvanmdev @itazap
interpolation added for TVP. (#30863)
fc53b84 
* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* Update TVP model to interpolate pre-trained image pad prompter encodings

* feat: Add 2D positional embeddings interpolation in TvpVisualInputEmbedding

* added required comments

* docstring and argument fix

* doc fixes and test case fix suggested in review.

* varibale typo fix

* styling and name fixes for padding interpolation flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhuvanmdev @amyeroberts