-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Falcon2-11B #30771
Support for Falcon2-11B #30771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's make the test go green and good to go!
For outside readers, this does not go against the philosophy as the falcon modeling code is already not very much in accordance to our philosophy 😉 (it has a lot of code paths etc).
Not super happy but it's the best compromise for this model
@@ -602,6 +602,25 @@ def test_lm_generate_falcon(self): | |||
|
|||
self.assertEqual(output_str, EXPECTED_OUTPUT) | |||
|
|||
@slow | |||
@require_bitsandbytes | |||
def test_lm_generate_falcon_11b(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding a test!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@ArthurZucker The tests have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
This PR adds support for the Falcon2-11B architecture.