Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix generate-related rendering issues #30600

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

gante
Copy link
Member

@gante gante commented May 1, 2024

What does this PR do?

See title :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@gante gante changed the title Docs: fix generate-related render issues Docs: fix generate-related rendering issues May 2, 2024
@@ -21,7 +21,7 @@ more. It also plays a role in a variety of mixed-modality applications that have
and vision-to-text. Some of the models that can generate text include
GPT2, XLNet, OpenAI GPT, CTRL, TransformerXL, XLM, Bart, T5, GIT, Whisper.

Check out a few examples that use [`~transformers.generation_utils.GenerationMixin.generate`] method to produce
Check out a few examples that use [`~generation.GenerationMixin.generate`] method to produce
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text was not being converted to a link. I've checked in the doc preview that it is now a link:
Screenshot 2024-05-02 at 12 23 01

@@ -256,25 +255,21 @@ class GenerationConfig(PushToHubMixin):
`batch_size`. Indicating a list enables different start ids for each element in the batch
(e.g. multilingual models with different target languages in one batch)


> Generation parameters exclusive to [assistant generation](https://arxiv.org/abs/2211.17192)
> Generation parameters exclusive to assistant generation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links do not work within the doc section header:
Screenshot 2024-05-02 at 12 24 11

@@ -218,8 +218,7 @@ class GenerationConfig(PushToHubMixin):
Switch to sequential beam search and sequential topk for contrastive search to reduce peak memory.
Used with beam search and contrastive search.


> Parameters that define the output variables of `generate`
> Parameters that define the output variables of generate
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special formatting with ` does not work here:
Screenshot 2024-05-02 at 12 24 48

@gante gante requested a review from amyeroberts May 2, 2024 11:25
@gante gante marked this pull request as ready for review May 2, 2024 11:25
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating all of these!

@gante gante merged commit aa55ff4 into huggingface:main May 2, 2024
8 checks passed
@gante gante deleted the docs_fix branch May 2, 2024 13:42
itazap pushed a commit that referenced this pull request May 14, 2024
* does this work?

* like this?

* fix the other generate links

* missing these
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants