Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug don't merge #30455

Closed
wants to merge 20 commits into from
Closed

debug don't merge #30455

wants to merge 20 commits into from

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 24, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

gugarosa added 18 commits April 23, 2024 05:08
@gugarosa
chore(root): Initial commit of Phi-3 files.
c1e38b0
@gugarosa
fix(root): Fixes Phi-3 missing on readme.
416eaa4
@gugarosa
fix(root): Ensures files are consistent.
e0b6815
@gugarosa
fix(phi3): Fixes unit tests.
912edf1
@gugarosa
fix(tests): Fixes style of phi-3 test file.
b62e6f3
@gugarosa
chore(tests): Adds integration tests for Phi-3.
508ec8e
@gugarosa
fix(phi3): Removes additional flash-attention usage, .e.g, swiglu and…
56e6464 
… rmsnorm.
@gugarosa
fix(phi3): Fixes incorrect docstrings.
9bc1f1f
@gugarosa
fix(phi3): Fixes docstring typos.
92d8379
@gugarosa
fix(phi3): Adds support for Su and Yarn embeddings.
c442d06
@gugarosa
fix(phi3): Improves according first batch of reviews.
d5aed89
@gugarosa
fix(phi3): Uses up_states instead of y in Phi3MLP.
3a24a1d
@gugarosa
fix(phi3): Uses gemma rotary embedding to support torch.compile.
4cfa767
@gugarosa
fix(phi3): Improves how rotary embedding classes are defined.
817fec7
@gugarosa
fix(phi3): Fixes inv_freq not being re-computed for extended RoPE.
9427419
@gugarosa
Merge remote-tracking branch 'upstream/main' into main
06cd06d
@gugarosa
fix(phi3): Adds last suggestions to modeling file.
2abcd4d
@gugarosa
fix(phi3): Splits inv_freq calculation in two lines.
aeb6ae7
@ydshieh ydshieh marked this pull request as draft April 24, 2024 15:00
@ydshieh ydshieh closed this Apr 24, 2024
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh mentioned this pull request Apr 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker Awaiting requested review from ArthurZucker ArthurZucker will be requested when the pull request is marked ready for review ArthurZucker is a code owner

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1 Rocketknight1 will be requested when the pull request is marked ready for review Rocketknight1 is a code owner

@stevhliu stevhliu Awaiting requested review from stevhliu stevhliu will be requested when the pull request is marked ready for review stevhliu is a code owner

Assignees
No one assigned
Labels
single-model-run-slow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydshieh @HuggingFaceDocBuilderDev @gugarosa