Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to HF repo/tree/revision when a file is missing #30406

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Apr 23, 2024

When cached_file fails to download a file from a valid HF model, it reports Checkout 'https://huggingface.co/{path_or_repo_id}/{revision}' for available files. But this gets a 404. The correct link would include /tree/{revision}.

I had the error come up when trying to load a tokenizer from a LoRA repo instead of the base model repo: https://colab.research.google.com/drive/1pqdFMgo_6kqHfCGR5-qCIC6A_py5f84H?usp=sharing

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit 04ac324 into huggingface:main Apr 23, 2024
20 checks passed
@mapmeld mapmeld deleted the 404fix branch May 9, 2024 22:58
itazap pushed a commit that referenced this pull request May 14, 2024
fix: link to HF repo tree when a file is missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants