Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi-device for more models #30379

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Enable multi-device for more models #30379

merged 5 commits into from
Apr 22, 2024
+5 −0

Conversation

jla524
Copy link
Contributor

@jla524 jla524 commented Apr 22, 2024 •
edited
Loading

What does this PR do?

Fixes #29786 (issue)

$ pytest tests/models/beit/test_modeling_beit.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 125 items / 118 deselected / 7 selected                                                                                          

tests/models/beit/test_modeling_beit.py ......s                                                                                      [100%]

<warnings redacted>
======================================== 6 passed, 1 skipped, 118 deselected, 3 warnings in 10.95s =========================================

$ pytest tests/models/blip/test_modeling_blip_text.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 80 items / 73 deselected / 7 selected                                                                                            

tests/models/blip/test_modeling_blip_text.py .......                                                                                 [100%]

<warnings redacted>
=============================================== 7 passed, 73 deselected, 1 warning in 2.61s ================================================

$ pytest tests/models/vitmatte/test_modeling_vitmatte.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 109 items / 102 deselected / 7 selected                                                                                          

tests/models/vitmatte/test_modeling_vitmatte.py .......                                                                              [100%]

<warnings redacted>
============================================== 7 passed, 102 deselected, 2 warnings in 5.10s ===============================================

$ pytest tests/models/vitmatte/test_modeling_vitmatte.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 109 items / 102 deselected / 7 selected                                                                                          

tests/models/vitmatte/test_modeling_vitmatte.py .......                                                                              [100%]

<warnings redacted>
============================================== 7 passed, 102 deselected, 2 warnings in 5.21s ===============================================

$ pytest tests/models/vivit/test_modeling_vivit.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 110 items / 103 deselected / 7 selected                                                                                          

tests/models/vivit/test_modeling_vivit.py .......                                                                                    [100%]

<warnings redacted>
============================================== 7 passed, 103 deselected, 2 warnings in 5.42s ===============================================

Who can review?

@amyeroberts

amyeroberts
amyeroberts approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great piece of work - thanks again for adding this feature to the models! ❤️

@amyeroberts amyeroberts merged commit 8b02bb6 into huggingface:main Apr 22, 2024
17 checks passed
@amyeroberts amyeroberts mentioned this pull request Apr 22, 2024
Open
59 tasks
zafstojano pushed a commit to zafstojano/transformers that referenced this pull request Apr 22, 2024
@jla524 @zafstojano
Enable multi-device for more models (huggingface#30379)
9bd4774 
* feat: support for vitmatte

* feat: support for vivit

* feat: support for beit

* feat: support for blip :D

* feat: support for data2vec
@jla524 jla524 deleted the more_multidevice branch April 22, 2024 22:14
itazap pushed a commit that referenced this pull request May 14, 2024
@jla524
Enable multi-device for more models (#30379)
2d383fc 
* feat: support for vitmatte

* feat: support for vivit

* feat: support for beit

* feat: support for blip :D

* feat: support for data2vec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community contribution: enabling device_map="auto" support for more vision and multimodal models
2 participants
@jla524 @amyeroberts