Fix missing prev_ci_results
#30313
Merged
Fix missing prev_ci_results
#30313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 18, 2024
Comment on lines
+60
to
+68
|
|
||
| # Upload complete failure tables, as they might be big and only truncated versions could be sent to Slack. | ||
| - name: Failure table artifacts | ||
| # Only the model testing job is concerned for this step | ||
| if: ${{ inputs.job == 'run_tests_gpu' }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: prev_ci_results | ||
| path: prev_ci_results |
There was a problem hiding this comment.
need to be before the second actions/checkout@v4 below
ydshieh
commented
Apr 18, 2024
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: prev_ci_results | ||
| path: prev_ci_results | ||
|
|
||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
this is the killer
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Apr 18, 2024
fix Co-authored-by: ydshieh <[email protected]>
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
fix Co-authored-by: ydshieh <[email protected]>
ydshieh
added a commit
that referenced
this pull request
Apr 23, 2024
fix Co-authored-by: ydshieh <[email protected]>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
fix Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#29914 added a new step in slack report workflow, but it used
actions/checkout@v4after the first part (about model CI job). This indeed removes all files in the same directory, so theactions/checkout@v4created in the first part is moved, and the last step of uploading artifact can't find it. This makes thenew mdoel failuresmissing in the slack report channel.