Make vitdet jit trace complient #30065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
requested review from
NielsRogge,
amyeroberts,
LysandreJik,
ArthurZucker and
xenova
3 tasks
amyeroberts
approved these changes
Apr 5, 2024
| @@ -441,8 +441,8 @@ def window_unpartition(windows, window_size, pad_height_width, height_width): | |||
| ) | |||
| hidden_state = hidden_state.permute(0, 1, 3, 2, 4, 5).contiguous().view(batch_size, patch_height, patch_width, -1) | |||
|
|
|||
| if patch_height > height or patch_width > width: | |||
| hidden_state = hidden_state[:, :height, :width, :].contiguous() | |||
| # We always have height <= patch_height and width <= patch_width | |||
There was a problem hiding this comment.
I think this was a victim of terrible variable naming - it should really be padded_height and padded_width. Patch height should always be less that or equal to height. I know it's not related to tracing, but could you update these for the sake of future readers?
NielsRogge
approved these changes
Apr 6, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes huggingface/optimum#1795 & huggingface/optimum#1582 (comment)