Fix wandb integration with SetFit model
#30021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
Apr 30, 2024
|
@ArthurZucker Done! |
tomaarsen
approved these changes
May 1, 2024
|
Just need the CIs to go Green 😉 you can rebase on main and run |
timothepearce
force-pushed
the
fix-wandb-integration-with-setfit
branch
from
f46c214 to
76ef8f6
Compare
|
@ArthurZucker That's what I did, but |
|
Just re-triggered them! |
timothepearce
force-pushed
the
fix-wandb-integration-with-setfit
branch
from
0b6b42f to
76ef8f6
Compare
timothepearce
force-pushed
the
fix-wandb-integration-with-setfit
branch
from
76ef8f6 to
3abbdb4
Compare
timothepearce
force-pushed
the
fix-wandb-integration-with-setfit
branch
from
3abbdb4 to
107d5df
Compare
|
the test seems unrelated so I think we can merge! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
itazap
pushed a commit
that referenced
this pull request
Jun 20, 2024
Fix W&B integration with SetFit model Co-authored-by: PEARCE Timothe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an error popping up while training a
SetFitModelwhile reporting towandb.To fix this issue, we could also subclass and override the
setupmethod specifically in thesetfitrepository, but that would be a much bigger job. @tomaarsen if think you're the one who should decide on that.Fixes # (issue)
huggingface/setfit#498
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@tomaarsen @ArthurZucker