Fix skipped gradient update of the last step when using gradient accumulation. #29561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes skipped gradient update of the last step when using gradient accumulation in trainer.py.
I'm not sure what is the meaning of 'step is always smaller than gradient_accumulation_steps', but steps_in_epoch <= args.gradient_accumulation_steps looks like always
False
.Thus, the update of the last iteration is skipped when gradient_accumulation_step > 1.
This also leads to different total iterations (-1 iteration per epoch).
It might be negligible, and the skipped gradients are used in next iteration, but I believe the gradient update behavior should be the same whether or not using gradient accumulation if the total batch size is the same.
I have tested with example script and the comparison results are here.
accelerator.accumulate() context manager now can handle the last step of data loader, so I'm trying to use it.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @pacman100