-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve _update_causal_mask performance #29210
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is there other changes you need to put in?
@ArthurZucker I think it can be merged, if I found additional optimizations I'll add them into another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you run the slow tests for both models? (otherwise I'll spin an instance and do it)
So, just ran locally FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_cpu_offload - AssertionError: Items in the second set but not the first:
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_disk_offload_bin - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_disk_offload_safetensors - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaModelTest::test_model_parallelism - AssertionError: Items in the second set but not the first:
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_cpu_offload - AssertionError: Items in the second set but not the first:
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_disk_offload_bin - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_disk_offload_safetensors - ValueError: You are trying to offload the whole model to the disk. Please use the `disk_offload` function instead.
FAILED tests/models/llama/test_modeling_llama.py::LlamaModelTest::test_model_parallelism - AssertionError: Items in the second set but not the first: In my env, |
Yes those are unrelated! |
Thanks for the PR 🤗 |
* Fix issue 29206 * Fix style
* Fix issue 29206 * Fix style
What does this PR do?
Fixes # (issue)
#29206
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker