Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop path being ignored in DINOv2 #29147

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Feb 20, 2024

What does this PR do?

A drop_path_rate parameter exists in the DINOv2 model, which is propagated all the way to the DINOv2 layers, but never used. This PR addresses this by using the drop path layers in the forward pass of the DINOv2 layers, and removing an (I think) unnecessary extra instantiation.

Fixes #29140.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts @NielsRogge @molbap

@fepegar fepegar mentioned this pull request Feb 20, 2024
4 tasks
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@amyeroberts amyeroberts merged commit c47576c into huggingface:main Feb 20, 2024
17 checks passed
@fepegar
Copy link
Contributor Author

fepegar commented Feb 20, 2024

Thanks for reviewing, @amyeroberts!

itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop path is ignored in DINOv2
2 participants