Save (circleci) cache at the end of a job #29141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
requested review from
ArthurZucker and
amyeroberts
and removed request for
ArthurZucker
ArthurZucker
approved these changes
Feb 20, 2024
ydshieh
commented
Feb 20, 2024
| @@ -264,6 +248,25 @@ def to_dict(self): | |||
|
|
|||
| steps.append({"store_artifacts": {"path": "~/transformers/tests_output.txt"}}) | |||
| steps.append({"store_artifacts": {"path": "~/transformers/reports"}}) | |||
|
|
|||
| # save cache at the end: so pytest step runs before cache saving and we can see results earlier | |||
There was a problem hiding this comment.
see them earlier on the console. The final results will be shown on a tab only when the whole job is finished.
amyeroberts
approved these changes
Feb 20, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
force-pushed
the
put_cache_saving_after
branch
from
4238e46 to
7e5d5fe
Compare
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
nice job Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This way,
pytestwill run beforecache savingand we have access to the results earlier in the case of partial or no cache loaded.