Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX [bnb / tests]: Fix currently failing bnb tests #29092

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

#29001 changed the logic of handling how to get linear layers from testing models. In fact, the model_type should always stay "gpt2" and not "openai-community/gpt2"

cc @amyeroberts @Titus-von-Koeller

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@younesbelkada younesbelkada merged commit a75a6c9 into main Feb 19, 2024
18 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch February 19, 2024 09:39
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Feb 19, 2024
younesbelkada added a commit that referenced this pull request Feb 20, 2024
#29122)

* forgot to push the changes for 4bit ..

* trigger CI
itazap pushed a commit that referenced this pull request May 14, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
#29122)

* forgot to push the changes for 4bit ..

* trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants