DeformableDetrModel support fp16 #29013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonggeunYu
commented
Feb 14, 2024
| @@ -64,7 +64,7 @@ at::Tensor ms_deform_attn_cuda_forward( | |||
| for (int n = 0; n < batch/im2col_step_; ++n) | |||
| { | |||
| auto columns = output_n.select(0, n); | |||
| AT_DISPATCH_FLOATING_TYPES(value.type(), "ms_deform_attn_forward_cuda", ([&] { | |||
| AT_DISPATCH_FLOATING_TYPES_AND_HALF(value.type(), "ms_deform_attn_forward_cuda", ([&] { | |||
There was a problem hiding this comment.
DonggeunYu
commented
Feb 14, 2024
Comment on lines
1543
to
1550
| def get_valid_ratio(self, mask, dtype=torch.float32): | ||
| """Get the valid ratio of all feature maps.""" | ||
|
|
||
| _, height, width = mask.shape | ||
| valid_height = torch.sum(mask[:, :, 0], 1) | ||
| valid_width = torch.sum(mask[:, 0, :], 1) | ||
| valid_ratio_heigth = valid_height.float() / height | ||
| valid_ratio_width = valid_width.float() / width | ||
| valid_ratio_heigth = valid_height.to(dtype) / height | ||
| valid_ratio_width = valid_width.to(dtype) / width |
There was a problem hiding this comment.
Reference:
transformers/src/transformers/models/oneformer/modeling_oneformer.py
Lines 1355 to 1364 in de6029a
amyeroberts
approved these changes
Feb 14, 2024
src/transformers/models/deformable_detr/modeling_deformable_detr.py
Outdated
Show resolved
Hide resolved
|
Actually, one thing we'll need to add is a test e.g. like here for MT5. For the quality checks, running |
…tr.py Co-authored-by: amyeroberts <[email protected]>
|
@amyeroberts |
amyeroberts
approved these changes
Feb 15, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hackyon
pushed a commit
to hackyon/transformers
that referenced
this pull request
Feb 15, 2024
* Update ms_deform_attn_cuda.cu * Update ms_deform_attn_cuda.cuh * Update modeling_deformable_detr.py * Update src/transformers/models/deformable_detr/modeling_deformable_detr.py Co-authored-by: amyeroberts <[email protected]> * Update modeling_deformable_detr.py * python utils/check_copies.py --fix_and_overwrite * Fix dtype missmatch error * Update test_modeling_deformable_detr.py * Update test_modeling_deformable_detr.py * Update modeling_deformable_detr.py * Update modeling_deformable_detr.py --------- Co-authored-by: amyeroberts <[email protected]>
5 tasks
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Update ms_deform_attn_cuda.cu * Update ms_deform_attn_cuda.cuh * Update modeling_deformable_detr.py * Update src/transformers/models/deformable_detr/modeling_deformable_detr.py Co-authored-by: amyeroberts <[email protected]> * Update modeling_deformable_detr.py * python utils/check_copies.py --fix_and_overwrite * Fix dtype missmatch error * Update test_modeling_deformable_detr.py * Update test_modeling_deformable_detr.py * Update modeling_deformable_detr.py * Update modeling_deformable_detr.py --------- Co-authored-by: amyeroberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR for DeformableDetrModel support fp16.
#29011
Who can review?
@amyeroberts