Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FA2 import + deprecation cycle #27330

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Nov 6, 2023

What does this PR do ?

This PR puts back is_flash_attn_available and make it go through a deprecation cycle. It was removed in this PR. As this method was never private, some remote modeling files used it. Fixes #27319

@SunMarc SunMarc changed the title put back import Fix FA2 import + deprecation cycle Nov 6, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 6, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you Marc!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

src/transformers/utils/import_utils.py Outdated Show resolved Hide resolved
@amyeroberts
Copy link
Collaborator

@SunMarc Merging so this can be part of a patch release.

@amyeroberts amyeroberts merged commit 721d1c8 into huggingface:main Nov 14, 2023
3 checks passed
LysandreJik pushed a commit that referenced this pull request Nov 14, 2023
* put back import

* switch to logger.warnings instead
Saibo-creator pushed a commit to epfl-dlab/transformers-GCD-PR that referenced this pull request Nov 15, 2023
* put back import

* switch to logger.warnings instead
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* put back import

* switch to logger.warnings instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants