Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken links to s-JoL/Open-Llama #27164

Merged

Conversation

CSRessel
Copy link
Contributor

What does this PR do?

I noticed a broken link in the README, for the source code of the Open-Llama model. This looks like it matches the docs where there's been a warning added:

This model is in maintenance mode only, so we won't accept any new PRs changing its code.

To reduce confusion (and link rot!) this PR updates all references to that code, by clarifying that the original source was removed.

For the previous discussion on model deprecation, see: #24922

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Potential reviewers might be @stevhliu or @MKhalusova since it's docs, or @amyeroberts who I've seen approve a lot of README edits today, or @sgugger has previously reviewed PR's related to Open-Llama.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tidy up - thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@amyeroberts amyeroberts merged commit b5c8e23 into huggingface:main Oct 31, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants