Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More error message fixup, plus some linebreaks! #26296

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

Rocketknight1
Copy link
Member

Followup to #26291 - I missed one of the messages! This PR also adds some linebreaks so they display without messy long lines and wrapping.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 20, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't use line breaks everywhere, only for relevant break! left a nit about that

src/transformers/dynamic_module_utils.py Outdated Show resolved Hide resolved
src/transformers/dynamic_module_utils.py Outdated Show resolved Hide resolved
src/transformers/dynamic_module_utils.py Outdated Show resolved Hide resolved
@Rocketknight1
Copy link
Member Author

Rocketknight1 commented Sep 21, 2023

Changes merged, gonna go ahead and merge the PR once CI is green.

@Rocketknight1 Rocketknight1 merged commit 000e52a into main Sep 21, 2023
@Rocketknight1 Rocketknight1 deleted the more_custom_code_error_rewrite branch September 21, 2023 16:36
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* More error message fixup, plus some linebreaks!

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* More error message fixup, plus some linebreaks!

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* More error message fixup, plus some linebreaks!

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/dynamic_module_utils.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants