-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More error message fixup, plus some linebreaks! #26296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't use line breaks everywhere, only for relevant break! left a nit about that
Co-authored-by: Arthur <[email protected]>
Co-authored-by: Arthur <[email protected]>
Co-authored-by: Arthur <[email protected]>
Changes merged, gonna go ahead and merge the PR once CI is green. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* More error message fixup, plus some linebreaks! * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> --------- Co-authored-by: Arthur <[email protected]>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* More error message fixup, plus some linebreaks! * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> --------- Co-authored-by: Arthur <[email protected]>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* More error message fixup, plus some linebreaks! * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> * Update src/transformers/dynamic_module_utils.py Co-authored-by: Arthur <[email protected]> --------- Co-authored-by: Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #26291 - I missed one of the messages! This PR also adds some linebreaks so they display without messy long lines and wrapping.