Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gated repo tests #26257

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix gated repo tests #26257

merged 2 commits into from
Sep 19, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 19, 2023

Related to this slack thread (private).

Since end of August (68fa9a5), gated repo tests were skipped because failing to pass. This was due to a server-side change that now makes the README files readable even on gated repo (since users have to be able to read a model card before requesting access). This PR fixes the tests -and unskip them- by trying to download gated_file.txt instead.

cc @ydshieh

@Wauplin Wauplin requested a review from ydshieh September 19, 2023 10:55
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Wauplin Wauplin merged commit 04191ea into main Sep 19, 2023
3 checks passed
@Wauplin Wauplin deleted the fix-gated-repo-tests branch September 19, 2023 11:25
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

MKhalusova pushed a commit to MKhalusova/transformers that referenced this pull request Sep 19, 2023
* Fix gated repo tests

* Apply suggestions from code review
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* Fix gated repo tests

* Apply suggestions from code review
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Fix gated repo tests

* Apply suggestions from code review
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* Fix gated repo tests

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants