-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom RMSNorm to ALL_LAYERNORM_LAYERS
#26227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also add IdeficsRMSNorm
and MegaRMSNorm
? 😉 (make sure make fixup
and make fix-copies
also pass!)
@ArthurZucker done!
do we want to add all these to transformers/src/transformers/models/mega/modeling_mega.py Lines 294 to 301 in 493b24b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! Let's add all of the mega ones as you said!
LlamaRMSNorm
to ALL_LAYERNORM_LAYERS
ALL_LAYERNORM_LAYERS
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
after discussion with @ArthurZucker, it seems best to limit to scope of this PR to adding custom RMSNorm to |
* add LlamaRMSNorm to ALL_LAYERNORM_LAYERS * fixup * add IdeficsRMSNorm to ALL_LAYERNORM_LAYERS and fixup
* add LlamaRMSNorm to ALL_LAYERNORM_LAYERS * fixup * add IdeficsRMSNorm to ALL_LAYERNORM_LAYERS and fixup
* add LlamaRMSNorm to ALL_LAYERNORM_LAYERS * fixup * add IdeficsRMSNorm to ALL_LAYERNORM_LAYERS and fixup
What does this PR do?
It fixed a issue discovered during discussion of PR #26152.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker