Fix ConversationalPipeline tests #26217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
Sep 18, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
MKhalusova
pushed a commit
to MKhalusova/transformers
that referenced
this pull request
Sep 19, 2023
Add BlenderbotSmall templates and correct handling for conversation.past_user_inputs
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
Add BlenderbotSmall templates and correct handling for conversation.past_user_inputs
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
Add BlenderbotSmall templates and correct handling for conversation.past_user_inputs
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
Add BlenderbotSmall templates and correct handling for conversation.past_user_inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing conversation pipeline tests in the CI. The causes were:
BlenderBotSmallwas missing adefault_chat_templateConversationobject distinguished between processed and unprocessed user inputs. The new object doesn't! This caused a couple of tests that were expecting the old behaviour to fail.ConversationalPipelinehas already been updated to handle the new behaviour, so only a few test values needed to be changed.