Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Updates to TTS task guide with regards to the new TTS pipeline #26095

Merged
merged 3 commits into from
Sep 12, 2023
Merged

[docs] Updates to TTS task guide with regards to the new TTS pipeline #26095

merged 3 commits into from
Sep 12, 2023

Conversation

MKhalusova
Copy link
Contributor

This PR adds:

  • An example of inference with the newly added text-to-speech pipeline
  • A necessary training code update to make sure the fine-tuned checkpoint is usable via the pipeline (saving the processor)
  • An introduction example of inference with Bark and a link to the course for more examples

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 11, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@MKhalusova MKhalusova marked this pull request as ready for review September 11, 2023 15:02
ylacombe
ylacombe approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@ylacombe ylacombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for updating it

I've left some really small suggestions, feel free to ignore them!

docs/source/en/tasks/text-to-speech.md Outdated Show resolved Hide resolved
docs/source/en/tasks/text-to-speech.md Outdated Show resolved Hide resolved
docs/source/en/tasks/text-to-speech.md Outdated Show resolved Hide resolved
amyeroberts
amyeroberts approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for adding this!

Vaibhavs10
Vaibhavs10 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @MKhalusova - I was going to add the same and saw that you've already done it. Just a wee suggestion to add info about VITS as well.

Thank you! ♥️

docs/source/en/tasks/text-to-speech.md Outdated Show resolved Hide resolved
sanchit-gandhi
sanchit-gandhi approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool - thanks for this update @MKhalusova!

docs/source/en/tasks/text-to-speech.md
To be able to use your checkpoint with a pipeline, make sure to save the processor with the checkpoint:

```py
>>> processor.save_pretrained("YOUR_ACCOUNT_NAME/speecht5_finetuned_voxpopuli_nl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if we omit the YOUR_ACCOUNT_NAME prefix, the processor will just be saved under the users' namespace automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, maybe. I think this way, it's rather consistent and definitely works :)

docs/source/en/tasks/text-to-speech.md
languages and for multiple speakers. Several text-to-speech models are currently available in 🤗 Transformers, such as
[Bark](../model_doc/bark), [MMS](../model_doc/mms), [VITS](../model_doc/vits) and [SpeechT5](../model_doc/speecht5).

You can easily generate audio using the `"text-to-audio"` pipeline (or its alias - `"text-to-speech"`). Some models, like Bark,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MKhalusova MKhalusova merged commit 1fe7ce4 into huggingface:main Sep 12, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@MKhalusova @ylacombe
@Vaibhavs10 @parambharat
[docs] Updates to TTS task guide with regards to the new TTS pipeline (…
d2198fb 
…huggingface#26095)

* tts guide updates with a pipeline

* Apply suggestions from code review

Co-authored-by: Yoach Lacombe <[email protected]>

* Update docs/source/en/tasks/text-to-speech.md

Co-authored-by: Vaibhav Srivastav <[email protected]>

---------

Co-authored-by: Yoach Lacombe <[email protected]>
Co-authored-by: Vaibhav Srivastav <[email protected]>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
@MKhalusova @ylacombe
@Vaibhavs10 @blbadger
[docs] Updates to TTS task guide with regards to the new TTS pipeline (…
957e611 
…huggingface#26095)

* tts guide updates with a pipeline

* Apply suggestions from code review

Co-authored-by: Yoach Lacombe <[email protected]>

* Update docs/source/en/tasks/text-to-speech.md

Co-authored-by: Vaibhav Srivastav <[email protected]>

---------

Co-authored-by: Yoach Lacombe <[email protected]>
Co-authored-by: Vaibhav Srivastav <[email protected]>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
@MKhalusova @ylacombe
@Vaibhavs10 @EduardoPach
[docs] Updates to TTS task guide with regards to the new TTS pipeline (…
2b34e70 
…huggingface#26095)

* tts guide updates with a pipeline

* Apply suggestions from code review

Co-authored-by: Yoach Lacombe <[email protected]>

* Update docs/source/en/tasks/text-to-speech.md

Co-authored-by: Vaibhav Srivastav <[email protected]>

---------

Co-authored-by: Yoach Lacombe <[email protected]>
Co-authored-by: Vaibhav Srivastav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchit-gandhi sanchit-gandhi sanchit-gandhi approved these changes

@ylacombe ylacombe ylacombe approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MKhalusova @HuggingFaceDocBuilderDev @Vaibhavs10 @amyeroberts @ylacombe @sanchit-gandhi