Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VITS] Only trigger tokenizer warning for uroman #25915

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

sanchit-gandhi
Copy link
Contributor

What does this PR do?

Warning should only be triggered if the tokenizer requires uromanization and the text contains non-roman characters

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@sanchit-gandhi sanchit-gandhi merged commit 3587769 into huggingface:main Sep 1, 2023
@sanchit-gandhi sanchit-gandhi deleted the vits-tokenizer branch September 1, 2023 18:27
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants