Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip offload tests for ViTDet #25913

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Skip offload tests for ViTDet #25913

merged 2 commits into from
Sep 4, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 1, 2023

What does this PR do?

Let's skip them for now. We can re-enable and fix them once this new model get more usage.

@ydshieh ydshieh requested a review from ArthurZucker September 1, 2023 15:26
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a TODO to not forget this is temporary?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 4, 2023

Added # TODO: Fix me (once this model gets more usage).

@ydshieh ydshieh merged commit b1d475f into main Sep 4, 2023
@ydshieh ydshieh deleted the skip_offload_tests_for_vitdet branch September 4, 2023 09:35
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* update

* fix

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants