Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤦update warning to If you want to use the new behaviour, set `legacy=… #25833

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Aug 29, 2023

What does this PR do?

Fixes #25828, the documentation was suggesting to use legacy=True instead of legacy=False to use the new behavior

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker marked this pull request as ready for review August 29, 2023 16:00
@ArthurZucker ArthurZucker merged commit 245dcc4 into huggingface:main Aug 29, 2023
@ArthurZucker ArthurZucker deleted the nit-doc-warning branch August 29, 2023 16:01
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
huggingface#25833)

🤦update warning to If you want to use the new behaviour, set `legacy=False`. instead of True
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
huggingface#25833)

🤦update warning to If you want to use the new behaviour, set `legacy=False`. instead of True
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
huggingface#25833)

🤦update warning to If you want to use the new behaviour, set `legacy=False`. instead of True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation issue, tokenization_llama.py, legacy = True
3 participants