[CLAP] Fix logit scales dtype for fp16 #25754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On some hardware, taking
torch.log
of a tensor in float16 on the CPU fails:Note that this only failed for me on a Colab T4, but not on a Titan RTX (used to test #25682).
Let's take
math.log
then convert it to a tensor - this will respect the dtype of the model but not taketorch.log
of a float16 CPU param.