[GPTNeo] Add input_embeds functionality to gpt_neo Causal LM
#25664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
yeah, a test would be helpful, at least on the models that have inputs_embeds in the signature of this fn! Sloppy reviewers (me!) miss issues like this one
cc @ydshieh -- lmk if you'd like to add it, or if you'd prefer me to add it :)
sgugger
approved these changes
Aug 22, 2023
I would appreciate you do it (you have super clear of the context already) - happy to review the PR ! |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow PR of #25659, were model inputs are updated with the input ids, meaning both input ids and input embeds are passed.