-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate: add missing logits processors docs #25653
Conversation
The documentation is not available anymore as the PR was closed or merged. |
I've confirmed that the previously missing docs are now properly rendered in the doc preview 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArthurZucker re tests -- fully on board. If you're okay with it, I'd like to do it on a separate PR :) Ditto for the side bar on the left, it is in need of an update! |
0c7ac54
to
5406873
Compare
5406873
to
e7c75a0
Compare
@ArthurZucker ready for a re-review! To recap, the previously reviewed version:
This version also:
In parallel, other concerns raised in the PR are being tackled in another places:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🤗 looks a lot better
What does this PR do?
Some logits processor classes were missing on the docs. This PR corrects it by:
1 - Adding all missing logits processors to the docs
2 - Adding missing top-level imports (to stay consistent with previously existing logits processors)