Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unnecesssary extra parameter #25643

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

rafaelpadilla
Copy link
Contributor

What does this PR do?

Fix errors raised when function self.normalize_annotation is called in 3 models.

There are 3 models (conditional detr, deformable detr and detr), whose self.normalize_annotation functions do not receive the input_data_format parameter.

input_data_format parameter was introduced in PR #25464 to allow images with unusual number of channels to be used. However, functions like self.normalize_annotation deal with annotations only, and don't need this parameter. In fact, this parameter raises an error, as it is not defined in the signature of the functions self.normalize_annotation.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 22, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants