Add docstrings and fix VIVIT examples #25628
Merged
+108
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrein
commented
Aug 21, 2023
Comment on lines
+705
to
+706
| >>> indices = sample_frame_indices(clip_len=32, frame_sample_rate=4, seg_len=container.streams.video[0].frames) | ||
| >>> video = read_video_pyav(container=container, indices=indices) |
There was a problem hiding this comment.
-
videoreaderwas an undeclared variable. It has been replaced with an equivalent code. -
When
seg_lenis set to the whole video lengthframe_sample_rateneeds to be set to4otherwise the model will assign a wrong class to the video invalidating the whole example.
| @@ -698,7 +717,7 @@ def forward( | |||
| >>> # model predicts one of the 400 Kinetics-400 classes | |||
| >>> predicted_label = logits.argmax(-1).item() | |||
| >>> print(model.config.id2label[predicted_label]) | |||
| eating spaghetti | |||
| LABEL_116 | |||
There was a problem hiding this comment.
The model actually doesn't output eating spaghetti it outputs LABEL_116which corresponds to eating spaghetti in kinetics 400.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Rocketknight1
approved these changes
Aug 25, 2023
|
@Geometrein Thanks for the PR - ping me whenever you're happy for me to merge! |
|
Thanks for your review @Rocketknight1! |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* fix docstrings and examples * docstring update * add missing whitespace
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* fix docstrings and examples * docstring update * add missing whitespace
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* fix docstrings and examples * docstring update * add missing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sample_frame_indicesmethodPytorch&VivitForVideoClassificationimportsvideoreadervariable.Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.