Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on Pipeline_webserver #25570

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

kihoon71
Copy link
Contributor

@kihoon71 kihoon71 commented Aug 17, 2023

docs: reorder the warning tip for pseudo-code

What does this PR do?

Fixed #25569, we modified the docs a little bit to clarify the suggested code is intentionally written.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil

docs: reorder the warning tip for pseudo-code

Co-Authored-By: Wonhyeong Seo <[email protected]>
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurZucker For core maintainer's confirmation :)

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the clarity of this doc! 🤗

docs/source/en/pipeline_webserver.md Outdated Show resolved Hide resolved
docs/source/en/pipeline_webserver.md Outdated Show resolved Hide resolved
@@ -74,6 +74,12 @@ curl -X POST -d "test [MASK]" http://localhost:8000/
중요한 점은 모델을 **한 번만** 가져온다는 것입니다. 따라서 웹 서버에는 모델의 사본이 없습니다. 이런 방식은 불필요한 RAM이 사용되지 않습니다. 그런 다음 큐 메커니즘을 사용하면, 다음과 같은
동적 배치를 사용하기 위해 추론 전 단계에 몇 개의 항목을 축적하는 것과 같은 멋진 작업을 할 수 있습니다:

<Tip warning={true}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can apply the same changes to the translation here

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위의(Above) should be 아래(below) for the context. We can also remove 당신의(your) for simplicity.

docs/source/ko/pipeline_webserver.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying !

@ArthurZucker ArthurZucker merged commit 08e3251 into huggingface:main Aug 18, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Suggestions on Pipeline_webserver

docs: reorder the warning tip for pseudo-code

Co-Authored-By: Wonhyeong Seo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ko/pipeline_webserver.md

Co-authored-by: Wonhyeong Seo <[email protected]>

---------

Co-authored-by: Wonhyeong Seo <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Improve dynamic batching example in pipeline_webserver.md
6 participants