Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPT CI #25548

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix MPT CI #25548

merged 1 commit into from
Aug 17, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 16, 2023

What does this PR do?

Hello, let's just fix this ....

@ydshieh ydshieh requested a review from ArthurZucker August 16, 2023 16:54
@@ -507,7 +507,7 @@ def test_model_logits(self):

outputs = model(dummy_input, output_hidden_states=True)

expected_slice = torch.Tensor([-0.2559, -0.2197, -0.2480]).to(torch_device, torch.bfloat16)
expected_slice = torch.Tensor([-0.2539, -0.2178, -0.1953]).to(torch_device, torch.bfloat16)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why the diff is so large ...

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, I think this was pytorch / kernel related so should be good cc @younesbelkada

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 17, 2023

Merge now. Leave comment if any @younesbelkada when you are back 🙏

@ydshieh ydshieh merged commit ec25306 into main Aug 17, 2023
@ydshieh ydshieh deleted the fix_mpt_hello branch August 17, 2023 07:06
@younesbelkada
Copy link
Contributor

Looks great @ydshieh , thanks!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 17, 2023

Hello

blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants