-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DINOv2] Add backbone class #25520
[DINOv2] Add backbone class #25520
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Overall looks good - just a few pieces to tidy up e.g. old files and print statements
@amyeroberts I've addressed your comments, feel free to approve/merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
Just a tiny tiny nit re an unneeded import. Otherwise - good to merge!
8b15e60
to
d4395cb
Compare
Co-authored-by: amyeroberts <[email protected]>
c1087e5
to
b0878b9
Compare
* First draft * More improvements * Fix all tests * More improvements * Add backbone test * Improve docstring * Address comments * Rename attribute * Remove expected output * Update src/transformers/models/dinov2/modeling_dinov2.py Co-authored-by: amyeroberts <[email protected]> * Fix style --------- Co-authored-by: amyeroberts <[email protected]>
* First draft * More improvements * Fix all tests * More improvements * Add backbone test * Improve docstring * Address comments * Rename attribute * Remove expected output * Update src/transformers/models/dinov2/modeling_dinov2.py Co-authored-by: amyeroberts <[email protected]> * Fix style --------- Co-authored-by: amyeroberts <[email protected]>
* First draft * More improvements * Fix all tests * More improvements * Add backbone test * Improve docstring * Address comments * Rename attribute * Remove expected output * Update src/transformers/models/dinov2/modeling_dinov2.py Co-authored-by: amyeroberts <[email protected]> * Fix style --------- Co-authored-by: amyeroberts <[email protected]>
What does this PR do?
This PR:
Dinov2Backbone
as it was requested at Integrating DINOv2 Backbone into Mask2Former for Semantic Segmentation NielsRogge/Transformers-Tutorials#343 and DINOv2 is now available in HF Transformers (with tutorial) facebookresearch/dinov2#153 (comment).