Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DINOv2] Add backbone class #25520

Merged
merged 11 commits into from
Aug 29, 2023
Merged

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Aug 15, 2023

@NielsRogge NielsRogge requested a review from amyeroberts August 15, 2023 10:37
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 15, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Overall looks good - just a few pieces to tidy up e.g. old files and print statements

tests/test_backbone_common.py Outdated Show resolved Hide resolved
src/transformers/models/dinov2/test.py Outdated Show resolved Hide resolved
src/transformers/models/dinov2/configuration_dinov2.py Outdated Show resolved Hide resolved
src/transformers/models/dinov2/modeling_dinov2.py Outdated Show resolved Hide resolved
src/transformers/models/dinov2/modeling_dinov2.py Outdated Show resolved Hide resolved
@NielsRogge
Copy link
Contributor Author

@amyeroberts I've addressed your comments, feel free to approve/merge :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Just a tiny tiny nit re an unneeded import. Otherwise - good to merge!

src/transformers/models/dinov2/modeling_dinov2.py Outdated Show resolved Hide resolved
@NielsRogge NielsRogge force-pushed the add_dinov2_backbone branch from 8b15e60 to d4395cb Compare August 24, 2023 17:56
@NielsRogge NielsRogge force-pushed the add_dinov2_backbone branch from c1087e5 to b0878b9 Compare August 25, 2023 19:37
@amyeroberts amyeroberts merged commit 77713d1 into huggingface:main Aug 29, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* First draft

* More improvements

* Fix all tests

* More improvements

* Add backbone test

* Improve docstring

* Address comments

* Rename attribute

* Remove expected output

* Update src/transformers/models/dinov2/modeling_dinov2.py

Co-authored-by: amyeroberts <[email protected]>

* Fix style

---------

Co-authored-by: amyeroberts <[email protected]>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* First draft

* More improvements

* Fix all tests

* More improvements

* Add backbone test

* Improve docstring

* Address comments

* Rename attribute

* Remove expected output

* Update src/transformers/models/dinov2/modeling_dinov2.py

Co-authored-by: amyeroberts <[email protected]>

* Fix style

---------

Co-authored-by: amyeroberts <[email protected]>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* First draft

* More improvements

* Fix all tests

* More improvements

* Add backbone test

* Improve docstring

* Address comments

* Rename attribute

* Remove expected output

* Update src/transformers/models/dinov2/modeling_dinov2.py

Co-authored-by: amyeroberts <[email protected]>

* Fix style

---------

Co-authored-by: amyeroberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants