Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for case where auxiliary_head is None in UperNetPreTrainedModel #25514

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mmurray
Copy link
Contributor

@mmurray mmurray commented Aug 15, 2023

What does this PR do?

UperNetConfig has an option called use_auxiliary_head. When use_auxiliary_head is False, the auxiliary_head is set to None. However, UperNetPreTrainedModel assumes that auxiliary_head is not None, resulting in an error when loading a pretrained upernet model with use_auxiliary_head=False (see issue #25513 ).

This pull request updates UperNetPreTrainedModel to appropriately handle the case where auxiliary_head is None.

Fixes #25513

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@sgugger sgugger merged commit df91ff5 into huggingface:main Aug 15, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
…Model` (huggingface#25514)

check for case where auxiliary_head is None in UperNetPreTrainedModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UperNetPreTrainedModel throws an AttributeError when use_auxiliary_head=False
2 participants