Revert "Reuse the cache created for latest main on PRs/branches if setup.py is not modified"
#25466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…uggingface#25466) Revert "Reuse the cache created for latest `main` on PRs/branches if `setup.py` is not modified (huggingface#25445)" This reverts commit 1d75768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25445
The way to solve the whole huge cache issue is to enable cache sharing between PRs from different forked repositories, see this doc.
If we decide to enable this (it's a dangerous take), then we can include the #25445 once the sharing is done.
More info: https://circleci.com/docs/oss/#pass-secrets-to-builds-from-forked-pull-requests