[Time series Informer] fix dtype of cumsum #25431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -647,7 +647,7 @@ def forward( | |||
| # calculate context for updating the attn_output, based on: | |||
| # https://github.com/zhouhaoyi/Informer2020/blob/ac59c7447135473fb2aafeafe94395f884d5c7a5/models/attn.py#L74 | |||
| if self.is_decoder: | |||
| context = value_states.cumsum(dim=-2) | |||
| context = value_states.cumsum(dim=-2, dtype=torch.float32).to(value_states.dtype) | |||
There was a problem hiding this comment.
Suggested change
| context = value_states.cumsum(dim=-2, dtype=torch.float32).to(value_states.dtype) | |
| context = value_states.cumsum(dim=-2, dtype=value_states.dtype) |
There was a problem hiding this comment.
so I wanted the cumsum to be in float32 to avoid overflow etc. and then cast...
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* fix dtype of cumsum * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an issue when training Informer with FP16, the
cumsumreturns float32.See report here: https://discuss.huggingface.co/t/how-to-train-on-multiple-gpus-the-informer-model-for-time-series-forecasting/48984/3