Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-KO] Translated docs: ko: pr_checks.md to Korean #24987

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

sronger
Copy link
Contributor

@sronger sronger commented Jul 21, 2023

What does this PR do?

Translated the pr_checks.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@sronger, @TaeYupNoh, @kj021, @HanNayeoniee, @eenzeenee, @sim-so

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sronger sronger changed the title docs: ko: pr_checks.md [i18n-KO] Translated docs: ko: pr_checks.md to Korean Jul 21, 2023
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 PR 고생 많으셨습니다! 🥳
마침 문서 번역을 위해 PR을 하고 있는 저희에게 참고가 되는 문서였어요.

특별한 오류를 발견하지 못해서 한국어 표현 위주로 리뷰를 드려보았는데요,
좋은 문장에 대한 생각은 모두 다를 수 있으니 모두 반영하지 않고 참고만 해주셔도 괜찮습니다! 😊

docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
docs/source/ko/pr_checks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TaeYupNoh TaeYupNoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sronger sronger marked this pull request as ready for review July 28, 2023 13:02
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation! We've recently added a section describing how the check_copies mechanism works. Would you like to translate that section as well? :)

@sronger
Copy link
Contributor Author

sronger commented Aug 17, 2023

Translation completed!
May you please review this PR? :)
@sgugger, @ArthurZucker, @eunseojo, @stevhliu

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit db816c6 into huggingface:main Aug 17, 2023
@sronger sronger deleted the ko-pr_checks branch August 23, 2023 06:33
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
)

* docs: ko: pr_checks.mdx

* feat: chatgpt draft

* fix: manual edits

* fix: resolve suggestions

Co-authored-by: Sohyun Sim <[email protected]>

* feat: chatgpt draft

* fix: manual edits

---------

Co-authored-by: Sohyun Sim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants