Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAPEX to the list of deprecated models #24859

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jul 17, 2023

What does this PR do?

TAPEX was not in the list of deprecated models, leading to importing it with the auto API not working. I'll make a script to check the content of that constant is in sync with the content of the deprecated folder so this doesn't happen again.

Fixes #24852

@sgugger sgugger requested review from ydshieh and LysandreJik July 17, 2023 15:29
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger closed this Jul 17, 2023
@sgugger sgugger reopened this Jul 17, 2023
@sgugger sgugger merged commit c21c373 into main Jul 17, 2023
@sgugger sgugger deleted the fix_deprecated_models branch July 17, 2023 16:53
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Add TAPEX to the list of deprecated models

* Add check

* Fix typo

* Fix import path for Van conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading model microsoft/tapex-base-finetuned-wtq failed with error No module named 'transformers.models.tapex'
4 participants