gpt-bigcode: avoid zero_ to support Core ML
#24755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-place `zeros_` is not supported by the Core ML conversion process. This PR replaces it with `zeros_like` so conversion can proceed. The change only affects a workaround for a PyTorch bug on the `cpu` device.
|
Note: to fully test conversion of |
|
The documentation is not available anymore as the PR was closed or merged. |
jlamypoirier
approved these changes
Jul 12, 2023
|
@younesbelkada I think this is already fixed in PT. |
|
We support versions of PyTorch from 1.10 and onward, so we need to keep the workaround for the bug. |
sgugger
approved these changes
Jul 12, 2023
|
Merging to unblock @pcuenca , let's maybe address @jlamypoirier 's comments in a follow up PR ! |
Lorenzobattistela
pushed a commit
to Lorenzobattistela/transformers
that referenced
this pull request
Jul 13, 2023
gpt-bigcode: avoid `zeros_` to support Core ML. In-place `zeros_` is not supported by the Core ML conversion process. This PR replaces it with `zeros_like` so conversion can proceed. The change only affects a workaround for a PyTorch bug on the `cpu` device.
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
gpt-bigcode: avoid `zeros_` to support Core ML. In-place `zeros_` is not supported by the Core ML conversion process. This PR replaces it with `zeros_like` so conversion can proceed. The change only affects a workaround for a PyTorch bug on the `cpu` device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In-place
zero_is not supported by the Core ML conversion process. This PR replaces it withzeros_likeso conversion can proceed.The change only affects a workaround for a PyTorch bug on the
cpudevice.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@younesbelkada, @loubnabnl, @jlamypoirier