Unpin huggingface_hub
#24667
Merged
Unpin huggingface_hub
#24667
+74
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jul 5, 2023
| @@ -116,8 +116,6 @@ def to_dict(self): | |||
| }, | |||
| ] | |||
| steps.extend([{"run": l} for l in self.install_steps]) | |||
| # TODO (ydshieh): Remove this line after the next release (the one after 2023/06/19) of `huggingface_hub` | |||
There was a problem hiding this comment.
This is the main objective of this PR.
ydshieh
commented
Jul 5, 2023
| - run: pip install --upgrade pip | ||
| - run: pip install -U GitPython | ||
| - run: pip install -U . | ||
| - run: pip install --upgrade --upgrade-strategy eager pip |
There was a problem hiding this comment.
so we can get newer versions when they are available.
ydshieh
commented
Jul 5, 2023
| @@ -136,20 +136,20 @@ jobs: | |||
| - checkout | |||
| - restore_cache: | |||
| keys: | |||
| - v0.6-code_quality-{{ checksum "setup.py" }} | |||
| - v0.6-code-quality | |||
| - v0.7-code_quality-{{ checksum "setup.py" }} | |||
There was a problem hiding this comment.
to include the new packages' versions (installed by this PR)
amyeroberts
approved these changes
Jul 5, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thank you @ydshieh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the release
0.16is out today.Also, use
--upgrade-strategy eagerinpip installwhich is required to respect this comment.The default
-U(which is associated withonly-if-needed) won't upgrade to all available new versions. See the doc:Since some packages are upgraded, let's change the cache version number for the new versions could be included in the cache.