Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated custom_tools.mdx to Korean #24580

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented Jun 29, 2023

What does this PR do?

Translated the custom_tools.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo
May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 29, 2023

The documentation is not available anymore as the PR was closed or merged.

@jungnerd
Copy link
Contributor

LGTM👍

@amyeroberts
Copy link
Collaborator

Thanks for the PR, @sim-so!

There's since been an update on main to all of our documentation files. Could you update the extension from .mdx to .md to match please?

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new type of documentation, but you translated it perfectly!
Thanks for the good translation 😀
Please check out the review below!

docs/source/ko/custom_tools.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_tools.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_tools.mdx Outdated Show resolved Hide resolved
@sim-so sim-so marked this pull request as ready for review July 16, 2023 00:24
@sim-so
Copy link
Contributor Author

sim-so commented Jul 16, 2023

Thanks for letting me know about the change! @amyeroberts!
I updated the extention to .md.

Could you review this PR?
@sgugger, @ArthurZucker, @eunseojo

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 9771ad3 into huggingface:main Jul 17, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* docs: ko: custom_tools.mdx

* feat: deepl draft

* fix: change .mdx to .md

* fix: resolve suggestions

* fix: resolve suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants