Update old existing feature extractor references #24552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
changed the title
ydshieh
approved these changes
Jun 28, 2023
|
|
||
| if push_to_hub: | ||
| if has_lm_head: | ||
| model_name = "dit-base" if "base" in checkpoint_url else "dit-large" | ||
| else: | ||
| model_name = "dit-base-finetuned-rvlcdip" if "dit-b" in checkpoint_url else "dit-large-finetuned-rvlcdip" | ||
| feature_extractor.push_to_hub( | ||
| image_processor.push_to_hub( | ||
| repo_path_or_name=Path(pytorch_dump_folder_path, model_name), | ||
| organization="nielsr", | ||
| commit_message="Add feature extractor", |
There was a problem hiding this comment.
randomly find something to improve 😆
commit_message="Add feature extractor",
to
commit_message="Add image processor",
| @@ -132,11 +132,11 @@ def convert_glpn_checkpoint(checkpoint_path, pytorch_dump_folder_path, push_to_h | |||
| config = GLPNConfig(hidden_sizes=[64, 128, 320, 512], decoder_hidden_size=64, depths=[3, 8, 27, 3]) | |||
|
|
|||
| # load feature extractor (only resize + rescale) | |||
There was a problem hiding this comment.
I got lucky today:
load image processor
I am going to buy loto
There was a problem hiding this comment.
:D You're more thorough than I! Can you tell I didn't search for "feature extractor" with a space?
| @@ -234,7 +234,7 @@ def convert_dpt_checkpoint(checkpoint_url, pytorch_dump_folder_path, push_to_hub | |||
| print(f"Saving model to {pytorch_dump_folder_path}") | |||
| model.save_pretrained(pytorch_dump_folder_path) | |||
| print(f"Saving feature extractor to {pytorch_dump_folder_path}") | |||
There was a problem hiding this comment.
Another one:
Saving image processor
| @@ -366,7 +366,7 @@ def convert_segformer_checkpoint(model_name, checkpoint_path, pytorch_dump_folde | |||
| logger.info(f"Saving PyTorch model and feature extractor to {pytorch_dump_folder_path}...") | |||
| @@ -147,12 +147,12 @@ def convert_swin_checkpoint(model_name, checkpoint_path, pytorch_dump_folder_pat | |||
| model.save_pretrained(pytorch_dump_folder_path) | |||
|
|
|||
| print(f"Saving feature extractor to {pytorch_dump_folder_path}") | |||
| feature_extractor.save_pretrained(pytorch_dump_folder_path) | |||
| image_processor.save_pretrained(pytorch_dump_folder_path) | |||
|
|
|||
| if push_to_hub: | |||
| print(f"Pushing model and feature extractor for {model_name} to hub") | |||
Co-authored by: Yih-Dar <[email protected]>
|
@ydshieh Thanks for pointing out the extra places I missed. I've updated + other vision files needing the same update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates a bunch of old references to feature extractors for vision models.
Most of the code isn't public facing in e.g. docs, but is often copied when new models are added.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.