Fixed OwlViTModel inplace operations #24529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
reviewed
Jun 27, 2023
| @@ -1293,8 +1293,8 @@ def forward( | |||
| return (pred_logits, image_class_embeds) | |||
|
|
|||
| # Normalize image and text features | |||
| image_class_embeds /= torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |||
| query_embeds /= torch.linalg.norm(query_embeds, dim=-1, keepdim=True) + 1e-6 | |||
| image_class_embeds = image_class_embeds / torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |||
There was a problem hiding this comment.
wait. I think we should do
(torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6) instead
There was a problem hiding this comment.
Suggested change
| image_class_embeds = image_class_embeds / torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |
| image_class_embeds = image_class_embeds / (torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6) |
ydshieh
requested changes
Jun 27, 2023
| @@ -1293,8 +1293,8 @@ def forward( | |||
| return (pred_logits, image_class_embeds) | |||
|
|
|||
| # Normalize image and text features | |||
| image_class_embeds /= torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |||
| query_embeds /= torch.linalg.norm(query_embeds, dim=-1, keepdim=True) + 1e-6 | |||
| image_class_embeds = image_class_embeds / torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |||
There was a problem hiding this comment.
Suggested change
| image_class_embeds = image_class_embeds / torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6 | |
| image_class_embeds = image_class_embeds / (torch.linalg.norm(image_class_embeds, dim=-1, keepdim=True) + 1e-6) |
|
The documentation is not available anymore as the PR was closed or merged. |
|
@pasqualedem Could you apply the commit suggestions, then we can merge 🙏 Thanks. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the "/=" operator in OwlViTModel which causes an error in the backward pass with the non-inplace version.
Fixes #24525
#24525
Who can review?
@ydshieh