TensorFlow CI fixes #24360
Merged
TensorFlow CI fixes #24360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Thank you @Rocketknight1 ! Works for me, but maybe with one more comment would be nice to reader if there is ever someone want to look our code.
| @@ -418,7 +418,8 @@ def build(self, input_shape): | |||
| if not self.built: | |||
| input_shape = input_shape.as_list() | |||
| # Conv1D output shapes are checked at build time since TF 2.7, so we need to account for padding | |||
| input_shape[-2] += self.explicit_padding * 2 | |||
| if input_shape[-2] is not None: | |||
| input_shape[-2] += self.explicit_padding * 2 | |||
There was a problem hiding this comment.
Could we add a short comment to explain why this condition? Even a link to a comment in one of your TF PR would be nice.
| @@ -452,7 +452,8 @@ def build(self, input_shape): | |||
| if not self.built: | |||
| input_shape = input_shape.as_list() | |||
| # Conv1D output shapes are checked at build time since TF 2.7, so we need to account for padding | |||
| input_shape[-2] += self.explicit_padding * 2 | |||
| if input_shape[-2] is not None: | |||
| input_shape[-2] += self.explicit_padding * 2 | |||
Comment on lines
+439
to
+441
| # This fails because the if return_loss: conditional can return None or a Tensor and TF hates that. | ||
| # We could fix that by setting the bool to a constant when exporting, but that requires a dedicated export | ||
| # function that we don't have yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a lot of changes to the TF tests, and this exposed a few issues. This PR fixes all the exposed issues, so hopefully after this the only remaining CI issues should be related to generation or the
SharedEmbeddingsrefactor.