Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order in GPTNeo's docstring #24358

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Jun 19, 2023

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qgallouedec Thanks for adding this fix!

It looks like most of the docstring doesn't match the method signature 👀 Would you be happy to update the rest of the docstring in this PR so it's correct?

@qgallouedec
Copy link
Member Author

Et voilà :)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 19, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤗 Thanks for iterating and contributing this improvement!

@amyeroberts
Copy link
Collaborator

@qgallouedec To get the setup_and_quality tests passing, you'll need to run make style at the top level of the repo and push any changes to this branch.

@amyeroberts amyeroberts merged commit c5454eb into huggingface:main Jun 19, 2023
@qgallouedec qgallouedec deleted the fix_docstring_sort_gpt_neo branch November 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants