Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EnCodec] Changes for 32kHz ckpt #24296

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

sanchit-gandhi
Copy link
Contributor

What does this PR do?

Updates the EnCodec config and modelling code to allow two options for the residual connection in the Resnet block:

  1. Pass the residual through a Conv1d
  2. Apply the residual directly (identity)

=> this change is required to use the latest 32kHz EnCodec model in the Music Gen model (#24109). It is tested for with a fast test, and confirmed to match the original implementation.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding this!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@sanchit-gandhi sanchit-gandhi merged commit 4124a09 into huggingface:main Jun 15, 2023
@sanchit-gandhi sanchit-gandhi deleted the encodec-skip-conv branch June 25, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants