Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the number of model test failures to slack CI report #24207

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 12, 2023

What does this PR do?

We decided to add deepspeed (nightly version) CI job to past CI in #22393. Also accelerate is installed with the main branch.
This makes the deepspeed CI job have quite a lot of failures most of the time. Sometimes we need to wait DS team for a fix, and sometimes a fix is required from HF.

Let's add an information regarding number of model test failures (i.e. not counting deepspeed CI job's failures) to the Slack CI report, so we have a number indicating the progress in past CI and make me feel a bit more of fulfillment 🙏 .

@ydshieh ydshieh requested a review from sgugger June 12, 2023 19:04
@ydshieh
Copy link
Collaborator Author

ydshieh commented Jun 12, 2023

The screenshot below shows the issue that motivates this PR

Screenshot 2023-06-12 205537

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh merged commit 41a8fa4 into main Jun 12, 2023
@ydshieh ydshieh deleted the bonbon branch June 12, 2023 19:27
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants