Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated bertology.mdx to Korean #23968

Merged
merged 4 commits into from
Jun 6, 2023
Merged

🌐 [i18n-KO] Translated bertology.mdx to Korean #23968

merged 4 commits into from
Jun 6, 2023

Conversation

wonhyeongseo
Copy link
Contributor

@wonhyeongseo wonhyeongseo commented Jun 3, 2023 •
edited
Loading

What does this PR do?

Translated the bertology.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@wonhyeongseo wonhyeongseo mentioned this pull request Jun 3, 2023
Closed
10 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo
Copy link
Contributor Author

  • Live preview is not working, although checks have passed. I confirmed there are no gotchas using GitHub Codespace. (We should create a pre-built environment (where all pip install commands are completed) for mentees and new-comers, preferably with preview --[lang] commands built-in as well)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

sim-so
sim-so reviewed Jun 3, 2023
View reviewed changes
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! 모두 좋습니다 😄

0525hhgus
0525hhgus suggested changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 😀
논문 내용이 잘 드러나도록 타이틀을 번역해주셨군요 👍
아래 짧은 리뷰를 남겼습니다!

docs/source/ko/bertology.mdx Outdated Show resolved Hide resolved
@wonhyeongseo @0525hhgus
fix: resolve suggestions
cef87f4 
Co-authored-by: Hyeonseo Yun <[email protected]>
@wonhyeongseo wonhyeongseo marked this pull request as ready for review June 6, 2023 03:53
@wonhyeongseo
Copy link
Contributor Author

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

ArthurZucker
ArthurZucker approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

@ArthurZucker ArthurZucker requested a review from sgugger June 6, 2023 08:40
@sgugger sgugger merged commit 7da3ce0 into huggingface:main Jun 6, 2023
@wonhyeongseo wonhyeongseo deleted the ko-bertology2 branch June 7, 2023 02:49
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@wonhyeongseo @0525hhgus @novice03
🌐 [i18n-KO] Translated bertology.mdx to Korean (huggingface#23968)
c135c7f 
* docs: ko: `bertology.mdx`

* feat: nmt draft

* fix: manual edits

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
@stevhliu stevhliu mentioned this pull request Aug 10, 2023
Open
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim-so sim-so sim-so left review comments

@0525hhgus 0525hhgus 0525hhgus requested changes

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@sgugger sgugger Awaiting requested review from sgugger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wonhyeongseo @HuggingFaceDocBuilderDev @0525hhgus @ArthurZucker @sim-so @sgugger