Remote code improvements #23959
Merged
Remote code improvements #23959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Lysandre Debut <[email protected]>
julien-c
reviewed
Jun 5, 2023
| ) | ||
|
|
||
|
|
||
| TIME_OUT_REMOTE_CODE = 30 |
There was a problem hiding this comment.
Have you ever seen @LysandreJik typing?
amyeroberts
approved these changes
Jun 6, 2023
LysandreJik
approved these changes
Jun 6, 2023
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* Fix model load when it has both code on the Hub and locally * Add input check with timeout * Add tests * Apply suggestions from code review Co-authored-by: Lysandre Debut <[email protected]> * Some non-saved stuff * Add feature extractors * Add image processor * Add model * Add processor and tokenizer * Reduce timeout --------- Co-authored-by: Lysandre Debut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a few improvements to the code on the Hub API, mainly:
trust_remote_codeis unset, we ask the user to validate or not (with a timeout of 30s for users launchin script)trust_remote_code=Falsewill execute the local code,trust_remote_code=Truethe one on the Hub