Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainer: fixed evaluate raising KeyError for ReduceLROnPlateau #23952

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Trainer: fixed evaluate raising KeyError for ReduceLROnPlateau #23952

merged 1 commit into from
Jun 2, 2023

Conversation

claudius-kienle
Copy link
Contributor

If the metric_for_best_model does not start with eval_, the trainer always appends the eval_ string before querying the metric value. Except in one code snippet, that only gets triggered if one uses the ReduceLROnPlateau scheduler.
I have added the check for eval like in the rest of the trainer.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 2, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 8940d31 into huggingface:main Jun 2, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…gingface#23952)

Trainer: fixed KeyError on evaluate for ReduceLROnPlateau

Co-authored-by: Claudius Kienle <[email protected]>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…gingface#23952)

Trainer: fixed KeyError on evaluate for ReduceLROnPlateau

Co-authored-by: Claudius Kienle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants